[webkit-changes] [WebKit/WebKit] 9217f7: InteractionRegions: should not look for link ances...

Commit Queue noreply at github.com
Fri May 12 19:54:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9217f7af3356a9dc4440f84d16d37718b3e937b4
      https://github.com/WebKit/WebKit/commit/9217f7af3356a9dc4440f84d16d37718b3e937b4
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    A LayoutTests/interaction-region/button-in-link-expected.txt
    A LayoutTests/interaction-region/button-in-link.html
    M LayoutTests/interaction-region/layer-tree-expected.txt
    M LayoutTests/interaction-region/paused-video-regions.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  InteractionRegions: should not look for link ancestors if a button ancestor has been found
https://bugs.webkit.org/show_bug.cgi?id=256718
<rdar://107958544>

Reviewed by Tim Horton.

Move all the `ancestorsOfType` matching to a single loop. Break when a
match is found.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):

* LayoutTests/interaction-region/button-in-link-expected.txt: Added.
* LayoutTests/interaction-region/button-in-link.html: Added.
New test covering this change.

* LayoutTests/interaction-region/layer-tree-expected.txt:
* LayoutTests/interaction-region/paused-video-regions.html:
Test gardening.

Canonical link: https://commits.webkit.org/264041@main




More information about the webkit-changes mailing list