[webkit-changes] [WebKit/WebKit] fcc5ab: [iOS] Spurious logging due to calling `-[UITextInt...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcc5abf6afac8fa170661622c030198e0da614df
      https://github.com/WebKit/WebKit/commit/fcc5abf6afac8fa170661622c030198e0da614df
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
    M Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm
    M Tools/WebKitTestRunner/ios/TestControllerIOS.mm
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

  Log Message:
  -----------
  [iOS] Spurious logging due to calling `-[UITextInteractionAssistant selectionView]` when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=256733
rdar://109281412

Reviewed by Wenson Hsieh.

When `UITextSelectionDisplayInteraction` is available, `-[UITextInteractionAssistant selectionView]`
logs a warning, saying it returns `nil`. This is frequently observed during layout tests,
particularly since `TestController::notifyDone` modifies the selection view.

To fix, guard all use of `-[UITextInteractionAssistant selectionView]` behind
`!HAVE(UI_TEXT_SELECTION_DISPLAY_INTERACTION)`.

* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView caretViewRectInContentCoordinates]):
(-[TestWKWebView selectionViewRectsInContentCoordinates]):
* Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::notifyDone):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::selectionStartGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionEndGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionCaretViewRect const):
(WTR::UIScriptControllerIOS::selectionRangeViewRects const):
(WTR::UIScriptControllerIOS::selectionCaretBackgroundColor const):

Canonical link: https://commits.webkit.org/264039@main