[webkit-changes] [WebKit/WebKit] abde73: ServiceWorkerStorageManager should only delete its...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abde730eecbb2d02dd8346c149c246ed28a78905
      https://github.com/WebKit/WebKit/commit/abde730eecbb2d02dd8346c149c246ed28a78905
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp
    M Source/WebCore/workers/service/server/SWRegistrationDatabase.h
    M Source/WebKit/NetworkProcess/storage/ServiceWorkerStorageManager.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm

  Log Message:
  -----------
  ServiceWorkerStorageManager should only delete its own files when clearing registrations
https://bugs.webkit.org/show_bug.cgi?id=256725
rdar://108841865

Reviewed by Chris Dumez.

Existing SPI allows clients to set the same path for different data types, so directory of ServiceWorkerStorageManager
might contain files for other types. Therefore, ServiceWorkerStorageManager should not remove the directory when
clearing registrations.

Test: WKWebsiteDataStoreConfiguration.SameCustomPathForDifferentTypes

* Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp:
(WebCore::SWRegistrationDatabase::~SWRegistrationDatabase):
(WebCore::SWRegistrationDatabase::close):
(WebCore::SWRegistrationDatabase::clearAllRegistrations):
* Source/WebCore/workers/service/server/SWRegistrationDatabase.h:
* Source/WebKit/NetworkProcess/storage/ServiceWorkerStorageManager.cpp:
(WebKit::ServiceWorkerStorageManager::clearAllRegistrations):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

Canonical link: https://commits.webkit.org/264036@main