[webkit-changes] [WebKit/WebKit] 6adf3d: Fix repainting for animated carets
mwyrzykowski
noreply at github.com
Fri May 12 13:34:49 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6adf3d29d4b6bd80d164bdc6a4e15edb36bb0b9c
https://github.com/WebKit/WebKit/commit/6adf3d29d4b6bd80d164bdc6a4e15edb36bb0b9c
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2023-05-12 (Fri, 12 May 2023)
Changed paths:
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
Log Message:
-----------
Fix repainting for animated carets
https://bugs.webkit.org/show_bug.cgi?id=256619
<radar://109174040>
Reviewed by Simon Fraser.
Simply using *partialRepaintRect is wrong. We should still be calling
computeRectForRepaint(...) and adjusting the rect as needed.
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::computeOutsetsFromInnerOuterRect):
(WebCore::repaintCaretForLocalRect):
Pass margins of the expanded rectangle.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::issueRepaint const):
(WebCore::RenderObject::repaintRectangle const):
* Source/WebCore/rendering/RenderObject.h:
Expand the rectangle after calling computeRectForRepaint
Canonical link: https://commits.webkit.org/264023@main
More information about the webkit-changes
mailing list