[webkit-changes] [WebKit/WebKit] 587028: [GPU Process] (REGRESSION 262607 at main): Copy pixel...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58702859275c833b40676afa1d2001fae6569959
      https://github.com/WebKit/WebKit/commit/58702859275c833b40676afa1d2001fae6569959
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M Source/WebKit/Shared/cg/ShareableBitmapCG.cpp

  Log Message:
  -----------
  [GPU Process] (REGRESSION 262607 at main): Copy pixels of CGImage only if it is not a sub-image
https://bugs.webkit.org/show_bug.cgi?id=255677
rdar://108072383

Reviewed by Simon Fraser.

In ShareableBitmap::createFromImagePixels(), CGImage and its CGDataProvider
may disagree about how many bytes are in the pixels buffers. CGImage is most
likely a sub-image of another CGImage which inherits its meta data but not
the full pixels buffer.

In this case we should fallback to ShareableBitmap::createFromImageDraw().
Ortherwise  ShareableBitmapConfiguration will falsely describe the data in the
SharedMemory.

* Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createFromImagePixels):

Canonical link: https://commits.webkit.org/264021@main