[webkit-changes] [WebKit/WebKit] 12d5ef: SVG syncbase animation no longer supports cyclic r...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12d5ef3e4f40bca9d7a18469a623ab8626ee6b39
      https://github.com/WebKit/WebKit/commit/12d5ef3e4f40bca9d7a18469a623ab8626ee6b39
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/cyclic-syncbase-expected.txt
    M Source/WebCore/svg/animation/SVGSMILElement.cpp
    M Source/WebCore/svg/animation/SVGSMILElement.h

  Log Message:
  -----------
  SVG syncbase animation no longer supports cyclic references

https://bugs.webkit.org/show_bug.cgi?id=256651

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Partial Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=162961

This patch removes the logic of reconnecting the conditions which was added before to support
dynamic interactions of eventbases using JS.
It was breaking the syncbase logic for cyclic references as there is common code used for both eventbases and syncbases.

* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(SVGSMILElement::resolveNextInterval): Remove 'bool notifyDependents' and usage
(SVGSMILElement::checkRestart): Ditto
(SVGSMILElement::seekToIntervalCorrespondingToTime): Ditto
(SVGSMILElement::progres): Add 'connectConditions'
* Source/WebCore/svg/animation/SVGSMILElement.h: Remove 'bool' argument from 'resolveNextInterval'
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/cyclic-syncbase-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/264018@main