[webkit-changes] [WebKit/WebKit] 64bb65: [IFC][line-clamp] ASSERT in canUseForLineLayoutWit...

Alan Baradlay noreply at github.com
Fri May 12 08:07:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64bb65a7a4c0c7e4839ec1ec4260b6780a8065a1
      https://github.com/WebKit/WebKit/commit/64bb65a7a4c0c7e4839ec1ec4260b6780a8065a1
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    A LayoutTests/fast/flexbox/line-clamp-empty-flex-item-assert-expected.txt
    A LayoutTests/fast/flexbox/line-clamp-empty-flex-item-assert.html
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

  Log Message:
  -----------
  [IFC][line-clamp] ASSERT in canUseForLineLayoutWithReason
https://bugs.webkit.org/show_bug.cgi?id=256684

Reviewed by Antti Koivisto.

We are not supposed to call canUseForLineLayoutWithReason with empty content anymore.
(RenderObject::childrenInline's default value is true)

* LayoutTests/fast/flexbox/line-clamp-empty-flex-item-assert-expected.txt: Added.
* LayoutTests/fast/flexbox/line-clamp-empty-flex-item-assert.html: Added.
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyModernLineClamp):

Canonical link: https://commits.webkit.org/264015@main




More information about the webkit-changes mailing list