[webkit-changes] [WebKit/WebKit] 4c392f: Media Controls not fading on click/tap when up.

megangardner noreply at github.com
Thu May 11 16:02:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c392f892c13fe6745da4cc09d02431b431b9de1
      https://github.com/WebKit/WebKit/commit/4c392f892c13fe6745da4cc09d02431b431b9de1
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js

  Log Message:
  -----------
  Media Controls not fading on click/tap when up.
https://bugs.webkit.org/show_bug.cgi?id=256565
rdar://109126598

Reviewed by Aditya Keerthi.

The code to check if a tap/click is in/on a media element was returing
true because of the "backdrop" element, which should not count as a
media control, even though it is part of the shadowdom. We should not
have pointer-events active on this element.
Also, I removed the code about also checking the container, as it was not
being used anywhere.

* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.isPointInControls):

Canonical link: https://commits.webkit.org/263987@main




More information about the webkit-changes mailing list