[webkit-changes] [WebKit/WebKit] a658f9: REGRESSION(261130 at main): Canvas putImageData draws...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a658f97638bf521b0cbfb4df91ad5c79b89aebb6
      https://github.com/WebKit/WebKit/commit/a658f97638bf521b0cbfb4df91ad5c79b89aebb6
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    A LayoutTests/fast/canvas/canvas-put-image-data-after-draw-expected.html
    A LayoutTests/fast/canvas/canvas-put-image-data-after-draw.html
    M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp

  Log Message:
  -----------
  REGRESSION(261130 at main): Canvas putImageData draws onto wrong canvas
https://bugs.webkit.org/show_bug.cgi?id=256151
rdar://108741153

Reviewed by Said Abou-Hallawa.

Pending reads are of form CGImage that points to the IOSurface.
Thus the IOSurface cannot be modified without synchronizing with the
GPUP.
Fix by simulating a write and synchronizing with the GPUP. After
this completes, there are no readers to the IOSurface and the
operation may proceed.

* LayoutTests/fast/canvas/canvas-put-image-data-after-draw-expected.html: Added.
* LayoutTests/fast/canvas/canvas-put-image-data-after-draw.html: Added.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::putPixelBuffer):

Canonical link: https://commits.webkit.org/263978@main