[webkit-changes] [WebKit/WebKit] a6ed79: WebProcessProxy should use default settings values...

Chris Dumez noreply at github.com
Thu May 11 10:24:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6ed791b6aab1c26bfeeb81eb353d777a4282cc0
      https://github.com/WebKit/WebKit/commit/a6ed791b6aab1c26bfeeb81eb353d777a4282cc0
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  -----------
  WebProcessProxy should use default settings values for near-suspended assertions when they have no page
https://bugs.webkit.org/show_bug.cgi?id=256648
rdar://108292314

Reviewed by Sihui Liu.

WebProcessProxy should use default settings values for near-suspended
assertions when they have no page. In WebKit, settings come from pages. The
WebProcessProxy therefore iterate through pages to figure out if it should take
near-suspended assertions and if it should drop them after a delay.

However, if the process doesn't have any pages, it would fall back to a value
that is not the default value for these settings, which would lead to
unexpected behavior in some case. This is particularly noticeable for service
worker processes which often don't have pages.

* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shouldTakeNearSuspendedAssertion const):
(WebKit::WebProcessProxy::shouldDropNearSuspendedAssertionAfterDelay const):

Canonical link: https://commits.webkit.org/263975@main




More information about the webkit-changes mailing list