[webkit-changes] [WebKit/WebKit] a54540: [WGSL] Delete unused parseExpression function
Tadeu Zagallo
noreply at github.com
Wed May 10 16:02:46 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a54540e1fb2dafaf5da2e996781dbcf848b1d25a
https://github.com/WebKit/WebKit/commit/a54540e1fb2dafaf5da2e996781dbcf848b1d25a
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
Log Message:
-----------
[WGSL] Delete unused parseExpression function
https://bugs.webkit.org/show_bug.cgi?id=256596
rdar://109162040
Reviewed by Dan Glastonbury.
The WGSL parser has a standalone parseExpression function that was used in testing,
but since AST nodes are now arena allocated, and the arenas' lifecycle is controlled
by the ShaderModule instance, it's no longer valid to return an AST node after the
module is destroyed, so this function should no longer be used.
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::parseExpression): Deleted.
* Source/WebGPU/WGSL/ParserPrivate.h:
Canonical link: https://commits.webkit.org/263935@main
More information about the webkit-changes
mailing list