[webkit-changes] [WebKit/WebKit] 008fcf: Regression(260812 at main): Hoyolab says phone is not...

Chris Dumez noreply at github.com
Wed May 10 15:03:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 008fcfb52edbe21d6b644659b48f70e6a593a64f
      https://github.com/WebKit/WebKit/commit/008fcfb52edbe21d6b644659b48f70e6a593a64f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebCore/platform/RuntimeApplicationChecks.h
    M Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

  Log Message:
  -----------
  Regression(260812 at main): Hoyolab says phone is not in portrait even though it is
https://bugs.webkit.org/show_bug.cgi?id=256612
rdar://106780607

Reviewed by Geoffrey Garen.

I added a linked-on-after flag for the Screen Orientation API in 260812 at main,
requiring apps to get rebuilt with the latest SDK in order to be able to use
the new API.

However, this broke the HoyoLab app, which now complains about the device
orientation even though it is correct. To address the issue, I am re-enabling
the screen orientation API for this app.

* Source/WebCore/platform/RuntimeApplicationChecks.h:
* Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isHoYoLAB):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultShouldEnableScreenOrientationAPI):

Canonical link: https://commits.webkit.org/263932@main




More information about the webkit-changes mailing list