[webkit-changes] [WebKit/WebKit] a87f48: Complex text path: Make tab glyph invisible after ...

Amanda Falke noreply at github.com
Wed May 10 14:14:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a87f4835223147224bbf8ab5ca6aceebc7a9c603
      https://github.com/WebKit/WebKit/commit/a87f4835223147224bbf8ab5ca6aceebc7a9c603
  Author: Amanda Falke <afalke at igalia.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/ComplexTextController.cpp

  Log Message:
  -----------
  Complex text path: Make tab glyph invisible after advancing
https://bugs.webkit.org/show_bug.cgi?id=256524

Reviewed by Fujii Hironori.

Other browsers never render any visible tab glyphs, even if the font has
a visible glyph for the tab character.

We need to ensure that complex text path does not render visible tab
glyphs. (Our patch in 249360 at main implemented this for simple text path;
we need to do this also for complex text path.)

Fixes test and brings complex text path into alignment with simple text
path tab character fixes we did in 249360 at main. In 261493 at main, we
recently began to render (some) control characters
in complex text path.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Canonical link: https://commits.webkit.org/263929@main




More information about the webkit-changes mailing list