[webkit-changes] [WebKit/WebKit] acb670: Fix signed division bias for power-of-two divisor ...

Commit Queue noreply at github.com
Wed May 10 12:50:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acb670a0a6d0437d39ba904083ee21ad89799a43
      https://github.com/WebKit/WebKit/commit/acb670a0a6d0437d39ba904083ee21ad89799a43
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    A JSTests/wasm/stress/divide-by-constant-power-of-two.js
    A JSTests/wasm/stress/remainder-by-constant-power-of-two.js
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  Fix signed division bias for power-of-two divisor in BBQ JIT
https://bugs.webkit.org/show_bug.cgi?id=256569
rdar://108073980

Reviewed by Yusuke Suzuki.

Fixes instruction selection for integer division and remainder
in BBQ JIT when the divisor is a constant power of two, with new
tests for the edge cases previously not covered by our suite.

* JSTests/wasm/stress/divide-by-constant-power-of-two.js: Added.
(async test):
* JSTests/wasm/stress/remainder-by-constant-power-of-two.js: Added.
(async test):
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add64):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitModOrDiv):

Canonical link: https://commits.webkit.org/263925@main




More information about the webkit-changes mailing list