[webkit-changes] [WebKit/WebKit] 36d90e: [GStreamer] video.loop cannot reliably be set on a...

Philippe Normand noreply at github.com
Wed May 10 12:40:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36d90edba1d7d514e50d1c84ba37a2f17d5cb1a5
      https://github.com/WebKit/WebKit/commit/36d90edba1d7d514e50d1c84ba37a2f17d5cb1a5
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M LayoutTests/media/video-played-collapse.html
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] video.loop cannot reliably be set on a paused pipeline
https://bugs.webkit.org/show_bug.cgi?id=256519

Reviewed by Xabier Rodriguez-Calvar.

Flushing seeks are now working again on looping videos when seamless seeking is not achievable.
Without this patch there is an infinite seek/didEnd loop at EOS for those cases.

* LayoutTests/media/video-played-collapse.html:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::isSeamlessSeekingEnabled const):

Canonical link: https://commits.webkit.org/263921@main




More information about the webkit-changes mailing list