[webkit-changes] [WebKit/WebKit] f11ea3: "Frame End" timeline point is wrong with UI-side c...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f11ea318b8fc5ab963b9d04f61e2cc1649b0ee6a
      https://github.com/WebKit/WebKit/commit/f11ea318b8fc5ab963b9d04f61e2cc1649b0ee6a
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
    M Source/WebCore/inspector/agents/InspectorTimelineAgent.h
    M Source/WebCore/page/Page.cpp

  Log Message:
  -----------
  "Frame End" timeline point is wrong with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=249796
rdar://103645351

Reviewed by Simon Fraser.

Have Page::didCompleteRenderingFrame drive InspectorFrameEnd by calling
into InspectorInstrumentation, which calls down into InspectorTimelineAgent.
Instead of incrementing m_runLoopNestingLevel for each InspectorFrameBegin
event, only increment when we have a corresponding didCompleteRenderingFrame
event.

* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCompleteRenderingFrameImpl):
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::eventDidResetAfterDispatch):
(WebCore::InspectorInstrumentation::didCompleteRenderingFrame):
* Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::didCompleteRenderingFrame):
* Source/WebCore/inspector/agents/InspectorTimelineAgent.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::didCompleteRenderingFrame):

Canonical link: https://commits.webkit.org/263917@main