[webkit-changes] [WebKit/WebKit] c51270: [iOS] Tapping full screen when in PIP causes blank...

Jer Noble noreply at github.com
Wed May 10 09:18:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5127002b1e4217a9a1eabff9d7517efbad9add8
      https://github.com/WebKit/WebKit/commit/c5127002b1e4217a9a1eabff9d7517efbad9add8
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

  Log Message:
  -----------
  [iOS] Tapping full screen when in PIP causes blank black screen
https://bugs.webkit.org/show_bug.cgi?id=256577
rdar://108065606

Reviewed by Eric Carlson.

When a page requests element fullscreen when the video inside the target is in PiP,
the state machine gets confused, thinking the app is existing auto-pip. This area
of code is deeply in need of a re-factoring, but until then, explicity return the
video layer to its original WebAVPlayerLayer at the end of didStopPictureInPicture().

* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):

Canonical link: https://commits.webkit.org/263907@main




More information about the webkit-changes mailing list