[webkit-changes] [WebKit/WebKit] eb2984: Non-unified builds after the debacle from 263719 at main

Adrian Perez noreply at github.com
Wed May 10 08:59:46 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb29847eefc881060496c662a3f285f0cff99aed
      https://github.com/WebKit/WebKit/commit/eb29847eefc881060496c662a3f285f0cff99aed
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp
    M Source/WebCore/accessibility/AccessibilitySlider.cpp
    M Source/WebCore/accessibility/AccessibilityTableCell.cpp
    M Source/WebCore/animation/AnimationTimeline.h
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/KeyframeEffectStack.cpp
    M Source/WebCore/bindings/js/JSMediaSessionCustom.cpp
    M Source/WebCore/css/SelectorFilter.cpp
    M Source/WebCore/css/query/MediaQueryFeatures.cpp
    M Source/WebCore/display/css/DisplayBoxFactory.cpp
    M Source/WebCore/dom/PositionIterator.cpp
    M Source/WebCore/dom/PseudoElement.cpp
    M Source/WebCore/editing/CompositeEditCommand.cpp
    M Source/WebCore/html/HTMLBRElement.cpp
    M Source/WebCore/html/shadow/ProgressShadowElement.cpp
    M Source/WebCore/html/shadow/SliderThumbElement.cpp
    M Source/WebCore/layout/floats/FloatingState.cpp
    M Source/WebCore/layout/formattingContexts/FormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/FormattingQuirks.cpp
    M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/block/BlockFormattingQuirks.cpp
    M Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.cpp
    M Source/WebCore/layout/layouttree/LayoutElementBox.cpp
    M Source/WebCore/mathml/MathMLRowElement.cpp
    M Source/WebCore/page/FrameSnapshotting.cpp
    M Source/WebCore/page/ImageOverlayController.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebCore/page/PrintContext.cpp
    M Source/WebCore/page/ScrollBehavior.cpp
    M Source/WebCore/rendering/AccessibilityRegionContext.cpp
    M Source/WebCore/rendering/BackgroundPainter.h
    M Source/WebCore/rendering/BorderEdge.cpp
    M Source/WebCore/rendering/BorderPainter.cpp
    M Source/WebCore/rendering/CaretRectComputation.cpp
    M Source/WebCore/rendering/GridLayoutFunctions.cpp
    M Source/WebCore/rendering/GridMasonryLayout.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/ImageQualityController.cpp
    M Source/WebCore/rendering/LegacyInlineBox.cpp
    M Source/WebCore/rendering/LegacyInlineElementBox.cpp
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyInlineIterator.cpp
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/OrderIterator.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderButton.cpp
    M Source/WebCore/rendering/RenderCombineText.cpp
    M Source/WebCore/rendering/RenderCounter.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderFragmentedFlow.cpp
    M Source/WebCore/rendering/RenderGeometryMap.cpp
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/rendering/RenderListBox.cpp
    M Source/WebCore/rendering/RenderMedia.cpp
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderQuote.cpp
    M Source/WebCore/rendering/RenderReplica.cpp
    M Source/WebCore/rendering/RenderRuby.cpp
    M Source/WebCore/rendering/RenderRubyBase.cpp
    M Source/WebCore/rendering/RenderRubyRun.cpp
    M Source/WebCore/rendering/RenderRubyText.cpp
    M Source/WebCore/rendering/RenderScrollbarPart.cpp
    M Source/WebCore/rendering/RenderSearchField.cpp
    M Source/WebCore/rendering/RenderSlider.cpp
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTableCaption.cpp
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCol.cpp
    M Source/WebCore/rendering/RenderTableRow.cpp
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/RenderTextControl.cpp
    M Source/WebCore/rendering/RenderTextControlMultiLine.cpp
    M Source/WebCore/rendering/RenderTextControlSingleLine.cpp
    M Source/WebCore/rendering/RenderTextFragment.cpp
    M Source/WebCore/rendering/RenderTextLineBoxes.cpp
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/RenderVTTCue.cpp
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebCore/rendering/StyledMarkedText.cpp
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextDecorationPainter.cpp
    M Source/WebCore/rendering/TextPaintStyle.cpp
    M Source/WebCore/rendering/line/LineInfo.cpp
    M Source/WebCore/rendering/line/LineWidth.cpp
    M Source/WebCore/rendering/line/TrailingObjects.cpp
    M Source/WebCore/rendering/mathml/MathOperator.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLMath.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
    M Source/WebCore/rendering/style/NinePieceImage.cpp
    M Source/WebCore/rendering/svg/LegacyRenderSVGPath.cpp
    M Source/WebCore/rendering/svg/LegacyRenderSVGShape.cpp
    M Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.cpp
    M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
    M Source/WebCore/rendering/svg/RenderSVGPath.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
    M Source/WebCore/rendering/svg/RenderSVGShape.cpp
    M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
    M Source/WebCore/style/ContainerQueryEvaluator.cpp
    M Source/WebCore/style/StyleChange.cpp
    M Source/WebCore/style/StyleFontSizeFunctions.cpp
    M Source/WebCore/style/StylePendingResources.cpp
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/Styleable.cpp
    M Source/WebKit/NetworkProcess/NetworkOriginAccessPatterns.cpp
    M Source/WebKit/NetworkProcess/NetworkOriginAccessPatterns.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/UIProcess/SubframePageProxy.cpp
    M Source/WebKit/WebProcess/WebSleepDisablerClient.cpp

  Log Message:
  -----------
  Non-unified builds after the debacle from 263719 at main
https://bugs.webkit.org/show_bug.cgi?id=256583

Unreviewed non-unified build fixes.

The changes in 263719 at main moved inlines into their own headers in some
cases, to try and make the build faster, but forgot to include the
FooInlines.h headers in many of the files where they are needed. This
patch fixes both cases of undefined types and linker errors due to
inline functions which were declared but never defined.

* Source/WebCore/accessibility/AccessibilityMathMLElement.cpp:
* Source/WebCore/accessibility/AccessibilitySlider.cpp:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
* Source/WebCore/animation/AnimationTimeline.h:
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
* Source/WebCore/bindings/js/JSMediaSessionCustom.cpp:
* Source/WebCore/css/SelectorFilter.cpp:
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
* Source/WebCore/display/css/DisplayBoxFactory.cpp:
* Source/WebCore/dom/PositionIterator.cpp:
* Source/WebCore/dom/PseudoElement.cpp:
* Source/WebCore/editing/CompositeEditCommand.cpp:
* Source/WebCore/html/HTMLBRElement.cpp:
* Source/WebCore/html/shadow/ProgressShadowElement.cpp:
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
* Source/WebCore/layout/floats/FloatingState.cpp:
* Source/WebCore/layout/formattingContexts/FormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/FormattingQuirks.cpp:
* Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp:
* Source/WebCore/layout/formattingContexts/block/BlockFormattingQuirks.cpp:
* Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
* Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.cpp:
* Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
* Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp:
* Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
* Source/WebCore/layout/layouttree/LayoutElementBox.cpp:
* Source/WebCore/mathml/MathMLRowElement.cpp:
* Source/WebCore/page/FrameSnapshotting.cpp:
* Source/WebCore/page/ImageOverlayController.cpp:
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
* Source/WebCore/page/PageColorSampler.cpp:
* Source/WebCore/page/PrintContext.cpp:
* Source/WebCore/page/ScrollBehavior.cpp:
* Source/WebCore/rendering/AccessibilityRegionContext.cpp:
* Source/WebCore/rendering/BackgroundPainter.h:
* Source/WebCore/rendering/BorderEdge.cpp:
* Source/WebCore/rendering/BorderPainter.cpp:
* Source/WebCore/rendering/CaretRectComputation.cpp:
* Source/WebCore/rendering/GridLayoutFunctions.cpp:
* Source/WebCore/rendering/GridMasonryLayout.cpp:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
* Source/WebCore/rendering/ImageQualityController.cpp:
* Source/WebCore/rendering/LegacyInlineBox.cpp:
* Source/WebCore/rendering/LegacyInlineElementBox.cpp:
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
* Source/WebCore/rendering/LegacyInlineIterator.cpp:
* Source/WebCore/rendering/LegacyInlineTextBox.cpp:
* Source/WebCore/rendering/LegacyLineLayout.cpp:
* Source/WebCore/rendering/MarkedText.cpp:
* Source/WebCore/rendering/OrderIterator.cpp:
* Source/WebCore/rendering/RenderBlock.cpp:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
* Source/WebCore/rendering/RenderButton.cpp:
* Source/WebCore/rendering/RenderCombineText.cpp:
* Source/WebCore/rendering/RenderCounter.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
* Source/WebCore/rendering/RenderGeometryMap.cpp:
* Source/WebCore/rendering/RenderImage.cpp:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderListBox.cpp:
* Source/WebCore/rendering/RenderMedia.cpp:
* Source/WebCore/rendering/RenderMenuList.cpp:
* Source/WebCore/rendering/RenderQuote.cpp:
* Source/WebCore/rendering/RenderReplica.cpp:
* Source/WebCore/rendering/RenderRuby.cpp:
* Source/WebCore/rendering/RenderRubyBase.cpp:
* Source/WebCore/rendering/RenderRubyRun.cpp:
* Source/WebCore/rendering/RenderRubyText.cpp:
* Source/WebCore/rendering/RenderScrollbarPart.cpp:
* Source/WebCore/rendering/RenderSearchField.cpp:
* Source/WebCore/rendering/RenderSlider.cpp:
* Source/WebCore/rendering/RenderTable.cpp:
* Source/WebCore/rendering/RenderTableCaption.cpp:
* Source/WebCore/rendering/RenderTableCell.cpp:
* Source/WebCore/rendering/RenderTableCol.cpp:
* Source/WebCore/rendering/RenderTableRow.cpp:
* Source/WebCore/rendering/RenderTableSection.cpp:
* Source/WebCore/rendering/RenderTextControl.cpp:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
* Source/WebCore/rendering/RenderTextControlSingleLine.cpp:
* Source/WebCore/rendering/RenderTextFragment.cpp:
* Source/WebCore/rendering/RenderTextLineBoxes.cpp:
* Source/WebCore/rendering/RenderTreeAsText.cpp:
* Source/WebCore/rendering/RenderVTTCue.cpp:
* Source/WebCore/rendering/RenderView.cpp:
* Source/WebCore/rendering/RenderWidget.cpp:
* Source/WebCore/rendering/StyledMarkedText.cpp:
* Source/WebCore/rendering/TextBoxPainter.cpp:
* Source/WebCore/rendering/TextDecorationPainter.cpp:
* Source/WebCore/rendering/TextPaintStyle.cpp:
* Source/WebCore/rendering/line/LineInfo.cpp:
* Source/WebCore/rendering/line/LineWidth.cpp:
* Source/WebCore/rendering/line/TrailingObjects.cpp:
* Source/WebCore/rendering/mathml/MathOperator.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLMath.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
* Source/WebCore/rendering/style/NinePieceImage.cpp:
* Source/WebCore/rendering/svg/LegacyRenderSVGPath.cpp:
* Source/WebCore/rendering/svg/LegacyRenderSVGShape.cpp:
* Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.cpp:
* Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
* Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
* Source/WebCore/style/StyleChange.cpp:
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
* Source/WebCore/style/StylePendingResources.cpp:
* Source/WebCore/style/StyleResolver.cpp:
* Source/WebCore/style/Styleable.cpp:
* Source/WebKit/NetworkProcess/NetworkOriginAccessPatterns.cpp:
(WebKit::NetworkOriginAccessPatterns::allowAccessTo):
* Source/WebKit/NetworkProcess/NetworkOriginAccessPatterns.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
* Source/WebKit/UIProcess/SubframePageProxy.cpp:
* Source/WebKit/WebProcess/WebSleepDisablerClient.cpp:

Canonical link: https://commits.webkit.org/263905@main

More information about the webkit-changes mailing list