[webkit-changes] [WebKit/WebKit] 22a69c: [CSS Nesting] Don't serialize the implicit parent ...

Matthieu Dubet noreply at github.com
Wed May 10 08:37:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22a69c73dd84b61a4a15ab5294b3880af1cb14a9
      https://github.com/WebKit/WebKit/commit/22a69c73dd84b61a4a15ab5294b3880af1cb14a9
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing.html
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp

  Log Message:
  -----------
  [CSS Nesting] Don't serialize the implicit parent selector in relative selector
https://bugs.webkit.org/show_bug.cgi?id=256578
rdar://109141615

Reviewed by Antti Koivisto.

Instead of inserting the implicit parent selector at parse time
(which makes it appears in the serialization),
we insert the resolved parent later (during rule set building).

* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing.html:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeStyleRule):
(WebCore::CSSParserImpl::consumeDeclarationListOrStyleBlockHelper):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::parseCSSSelector):
(WebCore::CSSSelectorParser::consumeRelativeNestedSelector):
(WebCore::CSSSelectorParser::resolveNestingParent):

Canonical link: https://commits.webkit.org/263902@main




More information about the webkit-changes mailing list