[webkit-changes] [WebKit/WebKit] 00afd6: Make SharedMemoryHandle non-copyable

Don Olmstead noreply at github.com
Wed May 10 07:00:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00afd6a353256ecc8010e64ac280ca4e1159825b
      https://github.com/WebKit/WebKit/commit/00afd6a353256ecc8010e64ac280ca4e1159825b
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebKit/Platform/SharedMemory.cpp
    M Source/WebKit/Platform/SharedMemory.h
    M Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp
    M Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
    M Source/WebKit/Platform/win/SharedMemoryWin.cpp
    M Source/WebKit/Shared/IPCStreamTester.cpp
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  -----------
  Make SharedMemoryHandle non-copyable
https://bugs.webkit.org/show_bug.cgi?id=256539

Reviewed by Kimmo Kinnunen.

Add `WTF_MAKE_NONCOPYABLE` to `SharedMemoryHandle`. Enumerate
constructors for the class.

Move common implementation of `SharedMemoryHandle` into common .cpp.

* Source/WebKit/Platform/SharedMemory.cpp:
(WebKit::SharedMemoryHandle::SharedMemoryHandle):
(WebKit::SharedMemoryHandle::isNull const):
* Source/WebKit/Platform/SharedMemory.h:
* Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::SharedMemoryHandle::isNull const): Deleted.
* Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemoryHandle::isNull const): Deleted.
* Source/WebKit/Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemoryHandle::isNull const): Deleted.
* Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::syncMessageReturningSharedMemory1):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSSharedMemory::createHandle):

Canonical link: https://commits.webkit.org/263897@main




More information about the webkit-changes mailing list