[webkit-changes] [WebKit/WebKit] 2df01f: HTML <blockquote>s are preserved in NSAttributedSt...

Gerald Squelart noreply at github.com
Tue May 9 17:08:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2df01fbd82d903cb5db3d42d2cdb4a68b1f542c1
      https://github.com/WebKit/WebKit/commit/2df01fbd82d903cb5db3d42d2cdb4a68b1f542c1
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/ios/UIKitSoftLink.h
    M Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm
    M Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h
    M Source/WebCore/editing/cocoa/AttributedString.h
    M Source/WebCore/editing/cocoa/AttributedString.mm
    M Source/WebCore/editing/cocoa/HTMLConverter.mm
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/NSAttributedStringWebKitAdditions.mm

  Log Message:
  -----------
  HTML <blockquote>s are preserved in NSAttributedStrings' NSPresentationIntents
https://bugs.webkit.org/show_bug.cgi?id=256514
rdar://105853449

Reviewed by Wenson Hsieh.

Block quotes are converted to NSPresentationIntents (of kind NSPresentationIntentKindBlockQuote), which may be nested as appropriate.

* Source/WebCore/PAL/pal/ios/UIKitSoftLink.h:
* Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:
* Source/WebCore/editing/cocoa/AttributedString.h:
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::toNSObject):
(WebCore::extractValue):
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverter::HTMLConverter):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_enterBlockquote):
(HTMLConverter::_exitBlockquote):
(HTMLConverter::_enterElement):
(HTMLConverter::_exitElement):
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):
Don't force strict secure coding on NSPresentationIntents (similar to NSParagraphStyles). Filed rdar://109121874 for follow-up.

* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NSAttributedStringWebKitAdditions.mm:

Canonical link: https://commits.webkit.org/263887@main




More information about the webkit-changes mailing list