[webkit-changes] [WebKit/WebKit] 150e2a: Signal::Usr is handled with mach after 260623 at main

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 150e2ad1ab3a419ca0cf82deb2e7b63a3c0ce4bd
      https://github.com/WebKit/WebKit/commit/150e2ad1ab3a419ca0cf82deb2e7b63a3c0ce4bd
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M Source/JavaScriptCore/jsc.cpp

  Log Message:
  -----------
  Signal::Usr is handled with mach after 260623 at main
https://bugs.webkit.org/show_bug.cgi?id=256550
rdar://109117815

Reviewed by Justin Michaud.

260623 at main made a change to move the handling of `JS_SHELL_WAIT_FOR_SIGUSR2_TO_EXIT` after
JSC options parsing, which enables signal handing using mach by default. `Signal::Usr` should
never be handled using mach, and when we attempt this we hit a release assertion in `toMachMask()`
causing JSC to crash when collecting vmmaps from a remote device. This patch fixes this by moving
where this signal handler is added back before mach exception handling is enabled.

* Source/JavaScriptCore/jsc.cpp:
(main):
(jscmain):

Canonical link: https://commits.webkit.org/263884@main