[webkit-changes] [WebKit/WebKit] d57954: AX: Fix various ITM tests after 263832 at main

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d57954fad0e97b8f2510f3699246d8f2f67b9898
      https://github.com/WebKit/WebKit/commit/d57954fad0e97b8f2510f3699246d8f2f67b9898
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M LayoutTests/accessibility/focusable-inside-hidden-expected.txt
    M LayoutTests/accessibility/focusable-inside-hidden.html
    M LayoutTests/accessibility/internal-link-anchors2-expected.txt
    M LayoutTests/accessibility/internal-link-anchors2.html
    M LayoutTests/accessibility/mac/content-editable-range-properties-expected.txt
    M LayoutTests/accessibility/mac/content-editable-range-properties.html
    M LayoutTests/accessibility/mac/html-with-aria-label.html
    M LayoutTests/platform/glib/accessibility/focusable-inside-hidden-expected.txt
    M LayoutTests/resources/accessibility-helper.js
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityTable.cpp

  Log Message:
  -----------
  AX: Fix various ITM tests after 263832 at main
https://bugs.webkit.org/show_bug.cgi?id=256496
rdar://problem/109063886

Reviewed by Ryosuke Niwa.

263832 at main changed the timing of AX object cache updates that some of our tests implicitly relied on.
These tests need to be made properly async to be immune to timing changes. This change also exposes bugs
where we dereference a null AXObjectCache assuming it will always be present -- we cannot make those
assumptions in some contexts anymore.

* LayoutTests/accessibility/focusable-inside-hidden-expected.txt:
* LayoutTests/accessibility/focusable-inside-hidden.html:
* LayoutTests/accessibility/internal-link-anchors2-expected.txt:
* LayoutTests/accessibility/internal-link-anchors2.html:
* LayoutTests/accessibility/mac/content-editable-range-properties-expected.txt:
* LayoutTests/accessibility/mac/content-editable-range-properties.html:
* LayoutTests/accessibility/mac/html-with-aria-label.html:
* LayoutTests/resources/accessibility-helper.js:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsPressAction const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject const):
(WebCore::AccessibilityRenderObject::addNodeOnlyChildren):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::headerContainer):

Canonical link: https://commits.webkit.org/263854@main