[webkit-changes] [WebKit/WebKit] b4ade8: Document::ListenerType should be an enum class

Ryosuke Niwa noreply at github.com
Mon May 8 18:27:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4ade8e6bda5fd5d1d936c513d4fe88d73e88287
      https://github.com/WebKit/WebKit/commit/b4ade8e6bda5fd5d1d936c513d4fe88d73e88287
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M Source/WebCore/animation/DeclarativeAnimation.cpp
    M Source/WebCore/dom/CharacterData.cpp
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/editing/markup.cpp
    M Source/WebCore/history/CachedFrame.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  Document::ListenerType should be an enum class
https://bugs.webkit.org/show_bug.cgi?id=256492

Reviewed by Chris Dumez.

Made Document::ListenerType an enum class and made m_listenerTypes an OptionSet.

Also introduced a new helper function: hasListenerTypeForEventType.

* Source/WebCore/animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::shouldFireDOMEvents const):
* Source/WebCore/dom/CharacterData.cpp:
(WebCore::canUseSetDataOptimization):
(WebCore::CharacterData::dispatchModifiedEvent):
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::hasListenerTypeForEventType const):
(WebCore::Document::addListenerTypeIfNeeded):
* Source/WebCore/dom/Document.h:
(WebCore::Document::hasListenerType const):
(WebCore::Document::hasAnyListenerOfType const): Added.
(WebCore::Document::addListenerType):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::dispatchFocusInEventIfNeeded):
(WebCore::Element::dispatchFocusOutEventIfNeeded):
(WebCore::Element::dispatchMouseForceWillBegin):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
* Source/WebCore/editing/markup.cpp:
(WebCore::hasMutationEventListeners):
* Source/WebCore/history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::didLayout):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):

Canonical link: https://commits.webkit.org/263844@main




More information about the webkit-changes mailing list