[webkit-changes] [WebKit/WebKit] 830fc5: document.write of template producing multiple text...

Ryosuke Niwa noreply at github.com
Mon May 8 17:53:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 830fc599637395e1d3260565dc1d8e84ad53f6ce
      https://github.com/WebKit/WebKit/commit/830fc599637395e1d3260565dc1d8e84ad53f6ce
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    A LayoutTests/fast/parser/template-multiple-child-text-nodes-expected.txt
    A LayoutTests/fast/parser/template-multiple-child-text-nodes.html
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write_single-expected.txt
    M Source/WebCore/html/parser/HTMLConstructionSite.cpp

  Log Message:
  -----------
  document.write of template producing multiple text nodes
https://bugs.webkit.org/show_bug.cgi?id=254334

Reviewed by Chris Dumez.

The bug was caused by HTMLConstructionSite::insertTextNode not considering the case where
the parent node is a template element in which case its text node is in its content fragment.

* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write_single-expected.txt:
* LayoutTests/fast/parser/template-multiple-child-text-nodes-expected.txt: Added.
* LayoutTests/fast/parser/template-multiple-child-text-nodes.html: Added.
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):

Canonical link: https://commits.webkit.org/263841@main




More information about the webkit-changes mailing list