[webkit-changes] [WebKit/WebKit] 3163f4: Fix false-positive bad release after calling H264B...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3163f4a6e89a3a907222d60e6ee0bdc2ce6f8a90
      https://github.com/WebKit/WebKit/commit/3163f4a6e89a3a907222d60e6ee0bdc2ce6f8a90
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm
    A Source/ThirdParty/libwebrtc/WebKit/0001-Fix-false-positive-bad-release-after-calling-H264Buf.patch

  Log Message:
  -----------
  Fix false-positive bad release after calling H264BufferToCMSampleBuffer/H265BufferToCMSampleBuffer
https://bugs.webkit.org/show_bug.cgi?id=256432
<rdar://109014853>

Reviewed by Youenn Fablet.

Add CF_RETURNS_RETAINED to both methods to fix the false
positive bad releases.  This lets the clang static analyzer
reason properly about the return value of these functions.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(H264BufferToCMSampleBuffer):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm:
(H265BufferToCMSampleBuffer):
* Source/ThirdParty/libwebrtc/WebKit/0001-Fix-false-positive-bad-release-after-calling-H264Buf.patch: Add.

Canonical link: https://commits.webkit.org/263800@main