[webkit-changes] [WebKit/WebKit] 927935: Update remote RTCDataChannel readyState initialisa...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 927935ae05e79398c2377e2903f2c636290d4e4b
      https://github.com/WebKit/WebKit/commit/927935ae05e79398c2377e2903f2c636290d4e4b
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ondatachannel-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/protocol/handover-datachannel-expected.txt
    M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
    M Source/WebCore/Modules/mediastream/RTCDataChannel.cpp
    M Source/WebCore/Modules/mediastream/RTCDataChannel.h
    M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp

  Log Message:
  -----------
  Update remote RTCDataChannel readyState initialisation
https://bugs.webkit.org/show_bug.cgi?id=256365
rdar://problem/108946592

Reviewed by Eric Carlson.

readyState should be set to open just before firing the datachannel event, while still scheduling the open event.

Side fix to use the mreo recent libwebrtc API for better conformance of maxPacketLifeTime and maxRetransmitsOpt.
This makes the whole LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ondatachannel.html file to pass.

* LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ondatachannel-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webrtc/protocol/handover-datachannel-expected.txt:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::newDataChannel):
* Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::RTCDataChannel):
* Source/WebCore/Modules/mediastream/RTCDataChannel.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:
(WebCore::LibWebRTCDataChannelHandler::dataChannelInit const):

Canonical link: https://commits.webkit.org/263775@main