[webkit-changes] [WebKit/WebKit] 23f4fb: AX: Avoid unnecessary main-thread trip to get sele...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23f4fb0fbfdee8c17afdf083080e0eeaf224e2e0
      https://github.com/WebKit/WebKit/commit/23f4fb0fbfdee8c17afdf083080e0eeaf224e2e0
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-05-06 (Sat, 06 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

  Log Message:
  -----------
  AX: Avoid unnecessary main-thread trip to get selectedTextRange() for secure fields
https://bugs.webkit.org/show_bug.cgi?id=256407
rdar://problem/108977135

Reviewed by Chris Fleizach.

Secure fields always return an empty selected text range. Since we cache
AXPropertyName::IsSecureField, we can use this information to avoid a
main-thread hit.

* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::shouldReturnEmptySelectedText const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::selectedTextRange const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::selectedTextRange const):

Canonical link: https://commits.webkit.org/263762@main