[webkit-changes] [WebKit/WebKit] aeaddd: [IFC] Remove redundant LineBuilder constructor

Alan Baradlay noreply at github.com
Sat May 6 08:37:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeaddddc170f66ccf5dcf3dec867fd34623cc396
      https://github.com/WebKit/WebKit/commit/aeaddddc170f66ccf5dcf3dec867fd34623cc396
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-06 (Sat, 06 May 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  [IFC] Remove redundant LineBuilder constructor
https://bugs.webkit.org/show_bug.cgi?id=256285

Reviewed by Antti Koivisto.

Intrinsic width codepath now can use LineBuilder as is (by passing in newly created temporary states), since LineBuilder does not mutate
any persistent state (box geometry) anymore.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::floatConstraints const):
(WebCore::Layout::LineBuilder::adjustLineRectForInitialLetterIfApplicable):
(WebCore::Layout::LineBuilder::tryPlacingFloatBox):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::inlineLayoutState const):
(WebCore::Layout::LineBuilder::blockLayoutState const):
(WebCore::Layout::LineBuilder::floatingState):
(WebCore::Layout::LineBuilder::floatingState const):

Canonical link: https://commits.webkit.org/263757@main




More information about the webkit-changes mailing list