[webkit-changes] [WebKit/WebKit] aa9c35: WebPage::mainFrameDidLayout() should not try to up...

Ryosuke Niwa noreply at github.com
Sat May 6 01:25:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa9c35538dcfa57baaa08ada18545d1f9f0de4ef
      https://github.com/WebKit/WebKit/commit/aa9c35538dcfa57baaa08ada18545d1f9f0de4ef
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-06 (Sat, 06 May 2023)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  WebPage::mainFrameDidLayout() should not try to update layout
https://bugs.webkit.org/show_bug.cgi?id=256386

Reviewed by Antti Koivisto.

Add a variant of pageCount which doesn't try to update layout
and call that variant in WebPage::mainFrameDidLayout.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pageScaleFactorChanged): Schedule
a event loop task to to update media controls instead of
synchronously updating it here as a post layout task.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::pageCount const):
(WebCore::Page::pageCountAssumingLayoutIsUpToDate const):

* Source/WebCore/page/Page.h:

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateRendering):
(WebKit::WebPage::mainFrameDidLayout): Moved the code to update
find controller and found text range controller to updateRendering.

Canonical link: https://commits.webkit.org/263751@main




More information about the webkit-changes mailing list