[webkit-changes] [WebKit/WebKit] db3c1d: [popover] Use dialog focus algorithm for dialog po...

Rob Buis noreply at github.com
Fri May 5 23:45:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db3c1dec69db0000cc3f5f3661d86c28bc67e28b
      https://github.com/WebKit/WebKit/commit/db3c1dec69db0000cc3f5f3661d86c28bc67e28b
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus.html
    M LayoutTests/platform/ios/fast/dom/focus-dialog-blur-input-type-change-crash-expected.txt
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Use dialog focus algorithm for dialog popovers
https://bugs.webkit.org/show_bug.cgi?id=256208

Reviewed by Tim Nguyen.

Implement the spec changes outlines here:
https://github.com/whatwg/html/pull/9121

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus.html: Added.
* LayoutTests/platform/ios/fast/dom/focus-dialog-blur-input-type-change-crash-expected.txt:
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::runFocusingSteps):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::runPopoverFocusingSteps):

Canonical link: https://commits.webkit.org/263749@main




More information about the webkit-changes mailing list