[webkit-changes] [WebKit/WebKit] 8cdc48: [LFC][initial-letter] LineBuilder should not mutat...

Alan Baradlay noreply at github.com
Fri May 5 19:07:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cdc48869bfdfe7bb53735a4cf9bbdcab65474cf
      https://github.com/WebKit/WebKit/commit/8cdc48869bfdfe7bb53735a4cf9bbdcab65474cf
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  [LFC][initial-letter] LineBuilder should not mutate BoxGeometry for initial-letter float box
https://bugs.webkit.org/show_bug.cgi?id=256281

Reviewed by Antti Koivisto.

Let's just use the normal float box process where box geometry is not mutated until after line layout.

* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::adjustLineRectForInitialLetterIfApplicable):
(WebCore::Layout::LineBuilder::tryPlacingFloatBox):
(WebCore::Layout::LineBuilder::adjustGeometryForInitialLetterIfNeeded): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/263743@main




More information about the webkit-changes mailing list