[webkit-changes] [WebKit/WebKit] f93732: CEReactions should always specify a value of Neede...

Ryosuke Niwa noreply at github.com
Fri May 5 11:34:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f93732930723b23b6a03cc77b8f7bb340bd08590
      https://github.com/WebKit/WebKit/commit/f93732930723b23b6a03cc77b8f7bb340bd08590
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M Source/WebCore/Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl
    M Source/WebCore/accessibility/AriaAttributes.idl
    M Source/WebCore/animation/WebAnimation.idl
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/IDLAttributes.json
    M Source/WebCore/bindings/scripts/test/TestCEReactions.idl
    M Source/WebCore/bindings/scripts/test/TestCEReactionsStringifier.idl
    M Source/WebCore/bindings/scripts/test/TestDelegateToSharedSyntheticAttribute.idl
    M Source/WebCore/bindings/scripts/test/TestDomainSecurity.idl
    M Source/WebCore/css/CSSStyleDeclaration.idl
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/dom/Attr.idl
    M Source/WebCore/dom/ChildNode.idl
    M Source/WebCore/dom/CustomElementRegistry.idl
    M Source/WebCore/dom/DOMStringMap.idl
    M Source/WebCore/dom/Document+HTML.idl
    M Source/WebCore/dom/Document+HTMLObsolete.idl
    M Source/WebCore/dom/Document.idl
    M Source/WebCore/dom/Element+DOMParsing.idl
    M Source/WebCore/dom/Element.idl
    M Source/WebCore/dom/ElementContentEditable.idl
    M Source/WebCore/dom/ElementInternals.idl
    M Source/WebCore/dom/InnerHTML.idl
    M Source/WebCore/dom/NamedNodeMap.idl
    M Source/WebCore/dom/Node.idl
    M Source/WebCore/dom/ParentNode.idl
    M Source/WebCore/dom/Range+DOMParsing.idl
    M Source/WebCore/dom/Range.idl
    M Source/WebCore/html/DOMTokenList.idl
    M Source/WebCore/html/HTMLAnchorElement.idl
    M Source/WebCore/html/HTMLDialogElement.idl
    M Source/WebCore/html/HTMLElement.idl
    M Source/WebCore/html/HTMLFieldSetElement.idl
    M Source/WebCore/html/HTMLFormElement.idl
    M Source/WebCore/html/HTMLIFrameElement.idl
    M Source/WebCore/html/HTMLImageElement.idl
    M Source/WebCore/html/HTMLLinkElement.idl
    M Source/WebCore/html/HTMLOptionElement.idl
    M Source/WebCore/html/HTMLOptionsCollection.idl
    M Source/WebCore/html/HTMLOrForeignElement.idl
    M Source/WebCore/html/HTMLOutputElement.idl
    M Source/WebCore/html/HTMLScriptElement.idl
    M Source/WebCore/html/HTMLSelectElement.idl
    M Source/WebCore/html/HTMLTableElement.idl
    M Source/WebCore/html/HTMLTableRowElement.idl
    M Source/WebCore/html/HTMLTableSectionElement.idl
    M Source/WebCore/html/HTMLTitleElement.idl
    M Source/WebCore/page/DOMSelection.idl
    M Source/WebCore/xml/XSLTProcessor.idl

  Log Message:
  -----------
  CEReactions should always specify a value of Needed or NotNeeded
https://bugs.webkit.org/show_bug.cgi?id=256276

Reviewed by Chris Dumez.

Explicitly specify whether each CEReactions is needed or not in IDL files.

Because WebKit does not implement customized bulletins, most instances of CEReactions
that only apply to subclasses of HTMLElement should take the value of NotNeeded.

This PR also replaces some CEReactions with CEReactions=NotNeeded where applicable.

* Source/WebCore/Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/animation/WebAnimation.idl:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateCustomElementReactionsStackIfNeeded):
* Source/WebCore/bindings/scripts/IDLAttributes.json:
* Source/WebCore/bindings/scripts/test/TestCEReactions.idl:
* Source/WebCore/bindings/scripts/test/TestCEReactionsStringifier.idl:
* Source/WebCore/bindings/scripts/test/TestDelegateToSharedSyntheticAttribute.idl:
* Source/WebCore/bindings/scripts/test/TestDomainSecurity.idl:
* Source/WebCore/css/CSSStyleDeclaration.idl:
* Source/WebCore/css/process-css-properties.py:
* Source/WebCore/dom/Attr.idl:
* Source/WebCore/dom/ChildNode.idl:
* Source/WebCore/dom/CustomElementRegistry.idl:
* Source/WebCore/dom/DOMStringMap.idl:
* Source/WebCore/dom/Document+HTML.idl:
* Source/WebCore/dom/Document+HTMLObsolete.idl:
* Source/WebCore/dom/Document.idl:
* Source/WebCore/dom/Element+DOMParsing.idl:
* Source/WebCore/dom/Element.idl:
* Source/WebCore/dom/ElementContentEditable.idl:
* Source/WebCore/dom/ElementInternals.idl:
* Source/WebCore/dom/InnerHTML.idl:
* Source/WebCore/dom/NamedNodeMap.idl:
* Source/WebCore/dom/Node.idl:
* Source/WebCore/dom/ParentNode.idl:
* Source/WebCore/dom/Range+DOMParsing.idl:
* Source/WebCore/dom/Range.idl:
* Source/WebCore/html/DOMTokenList.idl:
* Source/WebCore/html/HTMLAnchorElement.idl:
* Source/WebCore/html/HTMLDialogElement.idl:
* Source/WebCore/html/HTMLElement.idl:
* Source/WebCore/html/HTMLFieldSetElement.idl:
* Source/WebCore/html/HTMLFormElement.idl:
* Source/WebCore/html/HTMLIFrameElement.idl:
* Source/WebCore/html/HTMLImageElement.idl:
* Source/WebCore/html/HTMLLinkElement.idl:
* Source/WebCore/html/HTMLOptionElement.idl:
* Source/WebCore/html/HTMLOptionsCollection.idl:
* Source/WebCore/html/HTMLOrForeignElement.idl:
* Source/WebCore/html/HTMLOutputElement.idl:
* Source/WebCore/html/HTMLScriptElement.idl:
* Source/WebCore/html/HTMLSelectElement.idl:
* Source/WebCore/html/HTMLTableElement.idl:
* Source/WebCore/html/HTMLTableRowElement.idl:
* Source/WebCore/html/HTMLTableSectionElement.idl:
* Source/WebCore/html/HTMLTitleElement.idl:
* Source/WebCore/page/DOMSelection.idl:
* Source/WebCore/xml/XSLTProcessor.idl:

Canonical link: https://commits.webkit.org/263729@main




More information about the webkit-changes mailing list