[webkit-changes] [WebKit/WebKit] ccfcd8: Add support for `@font-face src tech()` and `@sup...

Vitor Roriz noreply at github.com
Fri May 5 11:20:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccfcd8af6c04a080d6350d17f33959d0a1ced378
      https://github.com/WebKit/WebKit/commit/ccfcd8af6c04a080d6350d17f33959d0a1ced378
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-tech-expected.txt
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/css/CSSFontFaceSrcValue.cpp
    M Source/WebCore/css/CSSFontFaceSrcValue.h
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp
    M Source/WebCore/css/parser/CSSSupportsParser.cpp
    M Source/WebCore/css/parser/CSSSupportsParser.h
    M Source/WebCore/platform/graphics/FontCustomPlatformData.h
    M Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp
    M Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
    M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp
    M Source/WebCore/svg/SVGFontFaceUriElement.cpp

  Log Message:
  -----------
  Add support for `@font-face src tech()` and  `@supports font-tech()` (252153)
https://bugs.webkit.org/show_bug.cgi?id=252153
rdar://105665900

Reviewed by Myles C. Maxfield.

Implementing @font-face src tech() [1] and @supports font-tech() [2]
according to:

[1] https://www.w3.org/TR/css-fonts-4/#font-face-src-parsing
[2] https://drafts.csswg.org/css-conditional-5/#typedef-supports-font-tech-fn

* LayoutTests/TestExpectations:
- We should pass this test now.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-tech-expected.txt:
- We pass all the subtests now, except for 2, since we don't support these
two font techonologies and techonologies are validated during parsing.

 * LayoutTests/platform/gtk/TestExpectations:
 * LayoutTests/platform/wpe/TestExpectations:
 - Skipping test for these platforms until webkit.org/b/256310 gets resolved.
 * LayoutTests/TestExpectations:
 * LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5-expected.txt:
 * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-tech-expected.txt:
 * Source/WebCore/css/CSSFontFaceSrcValue.cpp:
 (WebCore::CSSFontFaceSrcResourceValue::CSSFontFaceSrcResourceValue):
 (WebCore::CSSFontFaceSrcResourceValue::create):
 (WebCore::CSSFontFaceSrcResourceValue::customCSSText const):
 (WebCore::CSSFontFaceSrcResourceValue::equals const):
 * Source/WebCore/css/CSSFontFaceSrcValue.h:
 (WebCore::cssTextFromFontTech):
 * Source/WebCore/css/CSSPrimitiveValueMappings.h:
 (WebCore::fromCSSValueID):
 * Source/WebCore/css/CSSValueKeywords.in:
 * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
 (WebCore::CSSPropertyParserHelpers::consumeFontTech):
 * Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
 * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
 (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI):
 * Source/WebCore/css/parser/CSSSupportsParser.cpp:
 (WebCore::CSSSupportsParser::consumeSupportsFunction):
 (WebCore::CSSSupportsParser::consumeSupportsFontTechFunction):
 * Source/WebCore/css/parser/CSSSupportsParser.h:
 * Source/WebCore/platform/graphics/FontCustomPlatformData.h:
 * Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
 (WebCore::FontCustomPlatformData::supportsTech):
 * Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp:
 (WebCore::FontCustomPlatformData::supportsTech):
 * Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp:
 (WebCore::FontCustomPlatformData::supportsTech):
 * Source/WebCore/svg/SVGFontFaceUriElement.cpp:
 (WebCore::SVGFontFaceUriElement::createSrcValue const):

Canonical link: https://commits.webkit.org/263725@main




More information about the webkit-changes mailing list