[webkit-changes] [WebKit/WebKit] be4701: LocalFrameView::performPostLayoutTasks should not ...

Ryosuke Niwa noreply at github.com
Fri May 5 11:00:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be4701c3c0d1491a72cf568157a5e8e7d16e2639
      https://github.com/WebKit/WebKit/commit/be4701c3c0d1491a72cf568157a5e8e7d16e2639
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M LayoutTests/fast/dynamic/anchor-lock.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/fragment-scrolling-anchors.html
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  LocalFrameView::performPostLayoutTasks should not synchronously scroll to or focus an element (2)
https://bugs.webkit.org/show_bug.cgi?id=256353

Reviewed by Simon Fraser.

Somehow 263699 at main didn't contain the most crucial code change to make performPostLayoutTasks not
trigger synchronous scroll or focus so do that for real this time.

This PR also fixes tests that had assumed synchronous scroll anchoring.

* LayoutTests/fast/dynamic/anchor-lock.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/fragment-scrolling-anchors.html:

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed): Don't clear the scroll anchoring at the end for no reason.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::performPostLayoutTasks):

Canonical link: https://commits.webkit.org/263724@main




More information about the webkit-changes mailing list