[webkit-changes] [WebKit/WebKit] 074313: MediaSession should keep its action handlers alive

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0743137c2f4f602963fc409ebc56ecd6690d204d
      https://github.com/WebKit/WebKit/commit/0743137c2f4f602963fc409ebc56ecd6690d204d
  Author: Ryan Reno <rreno at apple.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M Source/WebCore/Modules/mediasession/MediaSession.cpp
    M Source/WebCore/Modules/mediasession/MediaSession.h
    M Source/WebCore/Modules/mediasession/MediaSession.idl
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/bindings/js/JSMediaSessionCustom.cpp

  Log Message:
  -----------
  MediaSession should keep its action handlers alive
https://bugs.webkit.org/show_bug.cgi?id=256334
rdar://108913983

Reviewed by Chris Dumez.

The MediaSessionActionHandler callback is now a weak reference and so
when the MediaSession is visited it needs to mark any action handlers
that have been added to it.

* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::setActionHandler):
(WebCore::MediaSession::callActionHandler):
* Source/WebCore/Modules/mediasession/MediaSession.h:
(WebCore::MediaSession::hasActiveActionHandlers const):
(WebCore::MediaSession::visitActionHandlers const):
* Source/WebCore/Modules/mediasession/MediaSession.idl:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSMediaSessionCustom.cpp: Added.
(WebCore::JSMediaSession::visitAdditionalChildren):

Canonical link: https://commits.webkit.org/263715@main