[webkit-changes] [WebKit/WebKit] bc2ea4: CSS Masonry Ensure Grid Size Updates on Resize

Brandon Stewart noreply at github.com
Thu May 4 23:07:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc2ea4d4cf826d62361b7744522954a7b4be96b0
      https://github.com/WebKit/WebKit/commit/bc2ea4d4cf826d62361b7744522954a7b4be96b0
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize.html
    M Source/WebCore/rendering/GridMasonryLayout.cpp

  Log Message:
  -----------
  CSS Masonry Ensure Grid Size Updates on Resize
https://bugs.webkit.org/show_bug.cgi?id=256337

Reviewed by Brent Fulgham.

During a resize of an element, the grid was not properly updating. The total grid size was remaining the same size while
the content was properly resized. This was caused by not clearing the m_gridContentSize at the start of the masonry algorithm.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize.html: Added.
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::performMasonryPlacement):

Canonical link: https://commits.webkit.org/263712@main




More information about the webkit-changes mailing list