[webkit-changes] [WebKit/WebKit] 1f2261: When the attachment "progress" is zero, show a pla...

Gerald Squelart noreply at github.com
Thu May 4 14:12:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f2261656aa215fbf8d4acde1d2986a6f205c5ce
      https://github.com/WebKit/WebKit/commit/1f2261656aa215fbf8d4acde1d2986a6f205c5ce
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/HTMLAttachmentElement.h
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  When the attachment "progress" is zero, show a placeholder icon
https://bugs.webkit.org/show_bug.cgi?id=256292
rdar://108266781

Reviewed by Aditya Keerthi and Tim Horton.

The arrow-down-circle placeholder is used to show that the attachment still needs to be downloaded.

* LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html:
* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::attachmentPlaceholderIdentifier):
(WebCore::attachmentProgressCSSProperty):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateProgress):
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-placeholder):
(div#attachment-save-icon):

Canonical link: https://commits.webkit.org/263696@main




More information about the webkit-changes mailing list