[webkit-changes] [WebKit/WebKit] 65b13c: Remove dead code: ModalContainerObserver and Modal...

Myles C. Maxfield noreply at github.com
Thu May 4 00:55:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65b13cfb8a8bcad17777b08c89f58d9fe7667232
      https://github.com/WebKit/WebKit/commit/65b13cfb8a8bcad17777b08c89f58d9fe7667232
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyClients.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/LocalFrameView.cpp
    R Source/WebCore/page/ModalContainerObserver.cpp
    R Source/WebCore/page/ModalContainerObserver.h
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/APIUIClient.h
    M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
    R Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.h
    R Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    R Tools/TestWebKitAPI/Tests/WebKit/modal-container-custom.html
    R Tools/TestWebKitAPI/Tests/WebKit/modal-container-with-overlay.html
    R Tools/TestWebKitAPI/Tests/WebKit/modal-container.html
    R Tools/TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Remove dead code: ModalContainerObserver and ModalContainerControlClassifier
https://bugs.webkit.org/show_bug.cgi?id=256289
rdar://108871402

Reviewed by Ryosuke Niwa.

Mechanical deletion.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::modalContainerObserver): Deleted.
(WebCore::Document::modalContainerObserverIfExists const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::classifyModalContainerControls): Deleted.
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::searchStringForModalContainerObserver const): Deleted.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::performPostLayoutTasks):
* Source/WebCore/page/ModalContainerObserver.cpp: Removed.
* Source/WebCore/page/ModalContainerObserver.h: Removed.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::overrideModalContainerSearchTermForTesting): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.h: Removed.
* Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm: Removed.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::classifyModalContainerControls): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions):
(WebKit::WebPageProxy::classifyModalContainerControls): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::classifyModalContainerControls): Deleted.
(WebKit::WebChromeClient::searchStringForModalContainerObserver const): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::classifyModalContainerControls): Deleted.

Canonical link: https://commits.webkit.org/263667@main




More information about the webkit-changes mailing list