[webkit-changes] [WebKit/WebKit] 5b9202: Flaky API Test: TestWTF.WTF_SynchronizedFixedQueue...

Fujii Hironori noreply at github.com
Wed May 3 23:23:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b9202cb4147f34728e00b156392ac54a0b9a0dc
      https://github.com/WebKit/WebKit/commit/5b9202cb4147f34728e00b156392ac54a0b9a0dc
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp

  Log Message:
  -----------
  Flaky API Test: TestWTF.WTF_SynchronizedFixedQueue.ProduceOnly
https://bugs.webkit.org/show_bug.cgi?id=195161

Reviewed by Said Abou-Hallawa.

TestWTF.WTF_SynchronizedFixedQueue.ProduceOnly was randomly timing out
on Windows. Produce thread was blocked by "m_upperQueue->enqueue(...)"
because m_upperQueue was full. This happened if the Produce thread was
running quicker than the main thread.

Doubled BufferSize of ToUpperConverter not to block the Produce thread
in the ProduceOnly test. And, run the test until produceCount reaches
the item count.

192736 at main (bug#176056) was the previous attempt to fix this dead
lock by slowing down the Produce thread. This change is no longer
needed. Reverted it.

* Tools/TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
(TestWebKitAPI::ToUpperConverter::startProducing):
(TestWebKitAPI::ToUpperConverter::stopProducing):

Canonical link: https://commits.webkit.org/263664@main




More information about the webkit-changes mailing list