[webkit-changes] [WebKit/WebKit] fcedcb: [Cocoa] [Shape Detection] WebKit crashes on launch...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcedcb75b10f017f98ec88d832d9fb01dd8921b6
      https://github.com/WebKit/WebKit/commit/fcedcb75b10f017f98ec88d832d9fb01dd8921b6
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm
    M Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [Cocoa] [Shape Detection] WebKit crashes on launch when on the base system
https://bugs.webkit.org/show_bug.cgi?id=256287
rdar://108870362

Reviewed by Aditya Keerthi.

Turns out the base system doesn't have Vision.framework or CoreML.framework. We were crashing
because we were statically linking with CoreML.framework. This patch makes us use soft linking
instead.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm:
(WebCore::ShapeDetection::configureRequestToUseCPUOrGPU):
* Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/263661@main