[webkit-changes] [WebKit/WebKit] fd8990: [popover] Update focus handling in hidePopover

Rob Buis noreply at github.com
Wed May 3 13:19:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd8990a116f4cf0d6ac2e2190062d44fc656ee08
      https://github.com/WebKit/WebKit/commit/fd8990a116f4cf0d6ac2e2190062d44fc656ee08
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Update focus handling in hidePopover
https://bugs.webkit.org/show_bug.cgi?id=256249

Reviewed by Ryosuke Niwa.

Only return focus to previously focused element if focus is within the popover hierarchy, since
the user may have tabbed the focus away from the popover since showPopover was called.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::hidePopoverInternal):

Canonical link: https://commits.webkit.org/263645@main




More information about the webkit-changes mailing list