[webkit-changes] [WebKit/WebKit] 8b741e: REGRESSION (iOS 16.4 / macOS 13.3): TestWTF.TypeCa...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b741e1d580dcc18ec14d8be401f97fab5b9d1b5
      https://github.com/WebKit/WebKit/commit/8b741e1d580dcc18ec14d8be401f97fab5b9d1b5
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M Source/WTF/wtf/cocoa/TypeCastsCocoa.h

  Log Message:
  -----------
  REGRESSION (iOS 16.4 / macOS 13.3): TestWTF.TypeCastsCocoaARC.bridge_cast is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=255243
<rdar://107849758>

Unreviewed partial revert of 261860 at main (b6a50d258a8e):

    Use bridge instead of reinterpret_cast to convert between NS and CF objects.
    <https://bugs.webkit.org/show_bug.cgi?id=253820>

* Source/WTF/wtf/cocoa/TypeCastsCocoa.h:
(WTF_NS_TO_CF_BRIDGE_TRANSFER): Revert change since this causes
leaks in macOS 13.3 and iOS 16.4 and later, and causes the
TestWTF.TypeCastsCocoaARC.bridge_cast test to fail on Release
builds.  It is the correct long-term change, but further fixes
are required to enable it.

Canonical link: https://commits.webkit.org/263639@main