[webkit-changes] [WebKit/WebKit] 6b0de0: Remove JavaScriptCore/bindings

Yusuke Suzuki noreply at github.com
Wed May 3 01:33:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b0de0073377b856dda88c4bbf010294b36a5f58
      https://github.com/WebKit/WebKit/commit/6b0de0073377b856dda88c4bbf010294b36a5f58
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    R Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp
    R Source/JavaScriptCore/bindings/ScriptFunctionCall.h
    R Source/JavaScriptCore/bindings/ScriptObject.cpp
    R Source/JavaScriptCore/bindings/ScriptObject.h
    R Source/JavaScriptCore/bindings/ScriptValue.cpp
    R Source/JavaScriptCore/bindings/ScriptValue.h
    M Source/JavaScriptCore/inspector/InjectedScript.cpp
    M Source/JavaScriptCore/inspector/InjectedScript.h
    M Source/JavaScriptCore/inspector/InjectedScriptBase.cpp
    M Source/JavaScriptCore/inspector/InjectedScriptBase.h
    M Source/JavaScriptCore/inspector/InjectedScriptManager.cpp
    M Source/JavaScriptCore/inspector/InjectedScriptModule.cpp
    A Source/JavaScriptCore/inspector/ScriptFunctionCall.cpp
    A Source/JavaScriptCore/inspector/ScriptFunctionCall.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/inspector/CommandLineAPIHost.cpp
    M Source/WebCore/inspector/InspectorFrontendHost.cpp

  Log Message:
  -----------
  Remove JavaScriptCore/bindings
https://bugs.webkit.org/show_bug.cgi?id=256033
rdar://problem/108596608

Reviewed by Darin Adler.

All files under JavaScriptCore/bindings were Deprecated::.

1. Remove ScriptValue and ScriptObject. Use Strong<> directly. We do not need these wrappers anymore.
2. Move ScriptFunctionCall to inspector/ since it is only used for inspector code, and still it is useful.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/bindings/ScriptObject.cpp: Removed.
* Source/JavaScriptCore/bindings/ScriptObject.h: Removed.
* Source/JavaScriptCore/bindings/ScriptValue.cpp: Removed.
* Source/JavaScriptCore/bindings/ScriptValue.h: Removed.
* Source/JavaScriptCore/inspector/InjectedScript.cpp:
(Inspector::InjectedScript::InjectedScript):
(Inspector::InjectedScript::execute):
(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::awaitPromise):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setEventValue):
(Inspector::InjectedScript::clearEventValue):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::findObjectById const):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):
(Inspector::InjectedScript::releaseObjectGroup):
(Inspector::InjectedScript::createCommandLineAPIObject const):
* Source/JavaScriptCore/inspector/InjectedScript.h:
* Source/JavaScriptCore/inspector/InjectedScriptBase.cpp:
(Inspector::jsToInspectorValue):
(Inspector::toInspectorValue):
(Inspector::InjectedScriptBase::InjectedScriptBase):
(Inspector::InjectedScriptBase::hasAccessToInspectedScriptState const):
(Inspector::InjectedScriptBase::injectedScriptObject const):
(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled const):
(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeEvalCall):
(Inspector::InjectedScriptBase::makeAsyncCall):
* Source/JavaScriptCore/inspector/InjectedScriptBase.h:
* Source/JavaScriptCore/inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::injectedScriptFor):
* Source/JavaScriptCore/inspector/InjectedScriptModule.cpp:
(Inspector::InjectedScriptModule::ensureInjected):
* Source/JavaScriptCore/inspector/ScriptFunctionCall.cpp: Renamed from Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp.
(Inspector::ScriptCallArgumentHandler::appendArgument):
(Inspector::ScriptFunctionCall::ScriptFunctionCall):
(Inspector::ScriptFunctionCall::call):
* Source/JavaScriptCore/inspector/ScriptFunctionCall.h: Renamed from Source/JavaScriptCore/bindings/ScriptFunctionCall.h.
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/inspector/CommandLineAPIHost.cpp:
* Source/WebCore/inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::InspectorFrontendHost::showContextMenu):

Canonical link: https://commits.webkit.org/263625@main




More information about the webkit-changes mailing list