[webkit-changes] [WebKit/WebKit] de2c64: AX: Allow 1px difference in results for mac/bounds...

Tyler Wilcock noreply at github.com
Tue May 2 20:32:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de2c64350b4c3eb105204fe08e2a2274971606c4
      https://github.com/WebKit/WebKit/commit/de2c64350b4c3eb105204fe08e2a2274971606c4
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/bounds-for-range-expected.txt
    M LayoutTests/accessibility/mac/bounds-for-range.html
    M LayoutTests/resources/accessibility-helper.js

  Log Message:
  -----------
  AX: Allow 1px difference in results for mac/bounds-for-range.html
https://bugs.webkit.org/show_bug.cgi?id=256218
rdar://problem/108800436

Reviewed by Chris Fleizach.

With https://bugs.webkit.org/show_bug.cgi?id=256179, there can sometimes be a 1px difference in
the results for this test. Worse, the difference is only between EWS and my local machine (both are consistent, but different).

With this patch, we allow a 1px difference in the results for this test by introducing a new
accessibility-helper.js function: expectRectWithVariance(expression, x, y, width, height, allowedVariance)

* LayoutTests/accessibility/mac/bounds-for-range-expected.txt:
* LayoutTests/accessibility/mac/bounds-for-range.html:
* LayoutTests/resources/accessibility-helper.js:

Canonical link: https://commits.webkit.org/263617@main




More information about the webkit-changes mailing list