[webkit-changes] [WebKit/WebKit] 08374b: [css-counter-styles] Port ethiopic counter styles ...

Tim Nguyen noreply at github.com
Tue May 2 13:55:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08374bddfb52a8231e7b4876949b3c2b63822386
      https://github.com/WebKit/WebKit/commit/08374bddfb52a8231e7b4876949b3c2b63822386
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M Source/WebCore/css/CSSCounterStyleRegistry.cpp
    M Source/WebCore/css/CSSCounterStyleRegistry.h
    M Source/WebCore/css/counterStyles.css
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [css-counter-styles] Port ethiopic counter styles to new codepath
https://bugs.webkit.org/show_bug.cgi?id=256158
rdar://108724140

Reviewed by Myles C. Maxfield.

Use converter at https://bugs.webkit.org/attachment.cgi?id=466153 to generate counter styles based on RenderListMarker data.
Note that this is supposed to be a 1:1 port from RenderListMarker, so there are places where we differ from the W3C ready-made counter styles.
rdar://108704382 has been filed to review them.

Also isCounterStyleUnsupportedByUserAgent is now removed and merged back to its call-site.

* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
(WebCore::isCounterStyleUnsupportedByUserAgent): Deleted.
* Source/WebCore/css/CSSCounterStyleRegistry.h:
* Source/WebCore/css/counterStyles.css:
(@counter-style afar):
(@counter-style ethiopic-halehame-ti-er):
(@counter-style ethiopic-halehame-ti-et):
(@counter-style oromo):
(@counter-style sidama):
(@counter-style tigre):
(@counter-style urdu):
(@counter-style amharic):
(@counter-style amharic-abegede):
(@counter-style ethiopic):
(@counter-style ethiopic-abegede):
(@counter-style somali):
(@counter-style tigrinya-er-abegede):
(@counter-style tigrinya-et-abegede):
(@counter-style ethiopic-abegede-gez):
(@counter-style ethiopic-abegede-am-et):
(@counter-style ethiopic-abegede-ti-er):
(@counter-style ethiopic-abegede-ti-et):
(@counter-style ethiopic-halehame-aa-et):
(@counter-style ethiopic-halehame-aa-er):
(@counter-style ethiopic-halehame-am-et):
(@counter-style ethiopic-halehame-gez):
(@counter-style ethiopic-halehame-om-et):
(@counter-style ethiopic-halehame-sid-et):
(@counter-style ethiopic-halehame-so-et):
(@counter-style ethiopic-halehame-tig):
(@counter-style tigrinya-er):
(@counter-style tigrinya-et):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertListStyleType):

Canonical link: https://commits.webkit.org/263602@main




More information about the webkit-changes mailing list