[webkit-changes] [WebKit/WebKit] cc94cc: fast/scrolling/ios/click-events-during-momentum-sc...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc94cce0848d72816737efdb85a3d469dd7e2cc3
      https://github.com/WebKit/WebKit/commit/cc94cce0848d72816737efdb85a3d469dd7e2cc3
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame-expected.txt
    M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html
    M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-expected.txt
    M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow.html

  Log Message:
  -----------
  fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=256192

Reviewed by Aditya Keerthi.

Adjust these two tests to (hopefully) be less flaky. These tests try to scroll via pan gesture, and
then tap in a web view during the deceleration phase of the scroll animation; however, it's
apparently possible for the test to synthesize the tap gesture while scrolling is still happening
(due to the pan gesture), reusing the touch identifier corresponding to the touch used for
scrolling.

Make this test more realistic (and also easier to follow) by removing the `noteTestProgress()`
counter mechanism, and instead simply wait for the scroll position to pass a certain threshold after
the event stream has ended.

Before this adjustment, I was able to reliably reproduce 1-2 test failures every 200 runs; after
this adjustment, I'm no longer able to reproduce any flaky failures.

* LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame-expected.txt:
* LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html:
* LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-expected.txt:
* LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow.html:

Canonical link: https://commits.webkit.org/263599@main