[webkit-changes] [WebKit/WebKit] 9aeb8b: Rename leading-trim to text-box-trim to match the ...

Alan Baradlay noreply at github.com
Tue May 2 07:49:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9aeb8b696f2d5f80fc2059972559160e83987442
      https://github.com/WebKit/WebKit/commit/9aeb8b696f2d5f80fc2059972559160e83987442
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderLayoutState.cpp
    M Source/WebCore/rendering/RenderLayoutState.h
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h

  Log Message:
  -----------
  Rename leading-trim to text-box-trim to match the latest spec
https://bugs.webkit.org/show_bug.cgi?id=256183

Reviewed by Tim Nguyen.

See https://www.w3.org/TR/css-inline-3/#leading-trim.

* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::initialValueForLonghand):
* Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h:
(WebCore::Layout::BlockLayoutState::BlockLayoutState):
(WebCore::Layout::BlockLayoutState::textBoxTrim const):
(WebCore::Layout::BlockLayoutState::leadingTrim const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::textBoxTrim const):
(WebCore::Layout::InlineLevelBox::inlineBoxContentOffsetForTextBoxTrim const):
(WebCore::Layout::InlineLevelBox::setInlineBoxContentOffsetForTextBoxTrim):
(WebCore::Layout::m_style):
(WebCore::Layout::InlineLevelBox::leadingTrim const): Deleted.
(WebCore::Layout::InlineLevelBox::inlineBoxContentOffsetForLeadingTrim const): Deleted.
(WebCore::Layout::InlineLevelBox::setInlineBoxContentOffsetForLeadingTrim): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalRectForTextRun const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::textBoxTrim):
(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::leadingTrim): Deleted.
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::pushLayoutState):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::TextBoxTrimmer::TextBoxTrimmer):
(WebCore::TextBoxTrimmer::~TextBoxTrimmer):
(WebCore::TextBoxTrimmer::setTextBoxTrimForSubtree):
(WebCore::TextBoxTrimmer::adjustTextBoxTrimAfterLayout):
(WebCore::RenderBlockFlow::layoutInFlowChildren):
(WebCore::LeadingTrimmer::LeadingTrimmer): Deleted.
(WebCore::LeadingTrimmer::~LeadingTrimmer): Deleted.
(WebCore::LeadingTrimmer::setLeadingTrimForSubtree): Deleted.
(WebCore::LeadingTrimmer::adjustLeadingTrimAfterLayout): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::RenderLayoutState::RenderLayoutState):
* Source/WebCore/rendering/RenderLayoutState.h:
(WebCore::RenderLayoutState::textBoxTrim):
(WebCore::RenderLayoutState::hasTextBoxTrimStart const):
(WebCore::RenderLayoutState::hasTextBoxTrimEnd const):
(WebCore::RenderLayoutState::resetTextBoxTrim):
(WebCore::RenderLayoutState::addTextBoxTrimStart):
(WebCore::RenderLayoutState::removeTextBoxTrimStart):
(WebCore::RenderLayoutState::addTextBoxTrimEnd):
(WebCore::RenderLayoutState::leadingTrim): Deleted.
(WebCore::RenderLayoutState::hasLeadingTrimStart const): Deleted.
(WebCore::RenderLayoutState::hasLeadingTrimEnd const): Deleted.
(WebCore::RenderLayoutState::resetLeadingTrim): Deleted.
(WebCore::RenderLayoutState::addLeadingTrimStart): Deleted.
(WebCore::RenderLayoutState::removeLeadingTrimStart): Deleted.
(WebCore::RenderLayoutState::addLeadingTrimEnd): Deleted.
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::textBoxTrim const):
(WebCore::RenderStyle::setTextBoxTrim):
(WebCore::RenderStyle::initialTextBoxTrim):
(WebCore::RenderStyle::leadingTrim const): Deleted.
(WebCore::RenderStyle::setLeadingTrim): Deleted.
(WebCore::RenderStyle::initialLeadingTrim): Deleted.
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

Canonical link: https://commits.webkit.org/263587@main




More information about the webkit-changes mailing list