[webkit-changes] [WebKit/WebKit] 0d0b88: REGRESSION(259145 at main): Crash when using 'current...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d0b8844e76c4d7a71f2d93de58b0c1bc49056cf
      https://github.com/WebKit/WebKit/commit/0d0b8844e76c4d7a71f2d93de58b0c1bc49056cf
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-05-01 (Mon, 01 May 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003.html
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  REGRESSION(259145 at main): Crash when using 'currentcolor' with color-mix() in color property
https://bugs.webkit.org/show_bug.cgi?id=256171
rdar://108698737

Reviewed by Darin Adler.

We were previously not handling `color-mix()` in the logic to resolve colors for `BuilderCustom::applyValueColor`.
Use StyleColor::resolveColor() which properly takes care of all cases.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003.html: Added.
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueColor):

Canonical link: https://commits.webkit.org/263556@main