[webkit-changes] [WebKit/WebKit] 6e7c8d: Can't activate feature with all caps tag via font-...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e7c8de0a165bc84743986dfccf6175e316a5fc3
      https://github.com/WebKit/WebKit/commit/6e7c8de0a165bc84743986dfccf6175e316a5fc3
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    A LayoutTests/fast/text/font-feature-settings-case-sensitive-expected.html
    A LayoutTests/fast/text/font-feature-settings-case-sensitive.html
    A LayoutTests/fast/text/resources/Ahem-feature-x-left-spacing.otf
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-valid-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp

  Log Message:
  -----------
  Can't activate feature with all caps tag via font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=254146
rdar://106966601

Reviewed by Tim Nguyen.

The CSS spec[1] says:

> The <string> is a case-sensitive OpenType feature tag.

Chrome and Firefox both treat it this way.

[1] http://w3c.github.io/csswg-drafts/css-fonts-4/#font-feature-settings-prop

Test: fast/text/font-feature-settings-case-sensitive.html

* LayoutTests/fast/text/font-feature-settings-case-sensitive-expected.html: Added.
* LayoutTests/fast/text/font-feature-settings-case-sensitive.html: Added.
* LayoutTests/fast/text/resources/Ahem-feature-x-left-spacing.otf: Added.
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontTag):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFeatureTagValue):

Canonical link: https://commits.webkit.org/262463@main